search

beeware / briefcase-android-gradle-template

A template for generating Android Gradle projects with Briefcase
MIT License
21 stars 22 forks source link

Handle bundles with dashes in the name #10

Closed freakboy3742 closed 4 years ago

freakboy3742 commented 4 years ago

Traveltips uses com.keith-magee.traveltips as it's full bundle name. However, this isn't a valid namespace for an Android package.

We need to modify the template to use a valid namespace for any valid bundle.

At the same time, we should verify that com.keith-magee.travel-tips also works. Briefcase already supports app_name and module_name to differentiate between travel-tips and travel_tips; we probably need an analogous transform for the bundle.

freakboy3742 commented 4 years ago

This has now been resolved, catching dashes in both the app and package name.