search

beeware / briefcase-android-gradle-template

A template for generating Android Gradle projects with Briefcase
MIT License
18 stars 19 forks source link

Compute pythonVersion dynamically #18

Closed paulproteus closed 4 years ago

paulproteus commented 4 years ago

This allows the same template to be used with any Python version. Computing the Python version takes between 0ms and 1ms on an Android emulator on my Mac Mini.

If we merge this, we can then immediately push the dev branch to 3.6 and 3.7 and 3.8.

Testing

I validated that an app works with a Python 3.6 or 3.7 or 3.8 virtualenv, using this template (no change to the template when switching Python versions). I did adjust the support_package to point to a local build of all those Python versions.

paulproteus commented 4 years ago

Makes sense; one potential problem flagged inline; and did you actually confirm the startup time impact? I'm guessing it won't be much, but just to be sure...

Yup, tested and it's been 0ms and 1ms on my Mac Mini's Android emulator.