beeware / briefcase-android-gradle-template

A template for generating Android Gradle projects with Briefcase
MIT License
18 stars 19 forks source link

Use separate locations for `app` and `app_packages` #2

Closed paulproteus closed 4 years ago

paulproteus commented 4 years ago

Implementation notes: Right now, the user's app and the dependencies are siblings in the filesystem tree. We need to mirror how the iOS briefcase target works in terms of separating the app and app_packages.

freakboy3742 commented 4 years ago

Fixed in #3.

paulproteus commented 4 years ago

@freakboy3742 Hi! Yay! BTW... do you know what I did wrong, syntax-wise? I was hoping that merging the PR would auto-close this?

freakboy3742 commented 4 years ago

@paulproteus So, AFAIK, the commit needs to start with "Fixes #N", (or Fix, Fixed, Closes, Close, Closed). I think that also applies to the PR title (since that becomes the first line of the merge commit message). Full reference is here.