Added BeewareSpinnerAdapter class

beeware / briefcase-android-gradle-template

A template for generating Android Gradle projects with Briefcase

MIT License

18 stars 19 forks source link

Added BeewareSpinnerAdapter class #40

Closed t-arn closed 2 years ago

t-arn commented 2 years ago

This PR adds org.beeware.android.BeewareSpinnerAdapter which is an extension of ArrayAdapter. BeewareSpinnerAdapter is used in the toga PR #1393 which implements Selection.set_font() for Android (and Winforms) https://github.com/beeware/toga/pull/1393

PR Checklist:

[x] All new features have been tested
[ ] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

t-arn commented 2 years ago

@freakboy3742 Please review this PR.

t-arn commented 2 years ago

hmm...I just realized that the dropdown list has a much smaller line spacing than the original Selection implementation. The items are difficult to hit. How can this be fixed?

t-arn commented 2 years ago

hmm...I just realized that the dropdown list has a much smaller line spacing than the original Selection implementation. The items are difficult to hit.

OK, fixed this problem

freakboy3742 commented 2 years ago

Closing on the basis that the underlying Toga ticket related to this issue has been closed.