Fixes #42 - Correct app crash when app was installed from Google Play (using AAB)

beeware / briefcase-android-gradle-template

A template for generating Android Gradle projects with Briefcase

MIT License

18 stars 19 forks source link

Fixes #42 - Correct app crash when app was installed from Google Play (using AAB) #43

Closed t-arn closed 2 years ago

t-arn commented 2 years ago

This PR fixes the issue #42

PR Checklist:

[x] All new features have been tested
[ ] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

t-arn commented 2 years ago

@freakboy3742 Please review this PR

t-arn commented 2 years ago

@freakboy3742 Russel, the gradle comment as you changed it, is now incorrect: libpython has always been included in the AAB and also in the distributed APK but it was not extracted from the APK to the file system of the device. If we changed the code in MainActivity.java, we could read the lib from the APK directly, saving the additional space on the file system. I thought, I'll leave that to Asheesh.

freakboy3742 commented 2 years ago

@t-arn I'll update the comment to reflect this.

As for other approaches: while @paulproteus did the original work for Android support, he did so under contract; as such, while he remains a friend of the project, we can't assume he will be available to address any bugs on an ongoing basis. If there's a better approach, then we should log this as a bug that someone could address.