Remove `fsdecode()` calls for `subprocess` commands - Githubissues

beeware / briefcase

Tools to support converting a Python project into a standalone native application.

https://briefcase.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

2.5k stars 354 forks source link

Remove `fsdecode()` calls for `subprocess` commands #1694

Closed rmartin16 closed 4 months ago

rmartin16 commented 4 months ago

Changes

Removes calls to os.fsdecode() for command arguments for subprocess calls
subprocess will call fsdecode() for subprocess command arguments for us
- Windows: subprocess always calls list2cmdlist for Windows processes
- POSIX: for posix_spawn path or the fork_exec path, everything has fsdecode called

PR Checklist:

[X] All new features have been tested
[X] All new features have been documented
[X] I have read the CONTRIBUTING.md file
[X] I will abide by the code of conduct