Support cookiecutter v2.6.0 - Githubissues

beeware / briefcase

Tools to support converting a Python project into a standalone native application.

https://briefcase.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

2.5k stars 354 forks source link

Support cookiecutter v2.6.0 #1724

Closed rmartin16 closed 3 months ago

rmartin16 commented 3 months ago

Changes

Closes #1663
v2.6.0 changed how jinja2 whitespace control configuration is respected; these changes ensure the rolled out Briefcase template matches the previous syntax.
Pins v2.6.0 as the lower end for cookiecutter

Notes

This should be merged in tandem with https://github.com/beeware/briefcase-template/pull/110

BRIEFCASE_TEMPLATE_REPO: https://github.com/rmartin16/briefcase-template BRIEFCASE_TEMPLATE_REF: template-whitespace

PR Checklist:

[x] All new features have been tested
[X] All new features have been documented
[X] I have read the CONTRIBUTING.md file
[X] I will abide by the code of conduct

rmartin16 commented 3 months ago

Templating a document where whitespace matters should be forbidden in international law.

That said, I've taken a more literal approach with the templating: basically, if you put whitespace in a value to be inserted in to the template, then that whitespace shows up in the template and attempts to "helpfully" collapse any of it have been removed. (The one exception 🙄 is the final template variable in the document....it will try to remove some extra whitespace at the end of the doc.)