Added Files using tenacity for retrying renaming a directory on a opened filepath.

beeware / briefcase

Tools to support converting a Python project into a standalone native application.

https://briefcase.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

2.48k stars 352 forks source link

Added Files using tenacity for retrying renaming a directory on a opened filepath. #1826

Open spa51273 opened 1 month ago

spa51273 commented 1 month ago

Fixes #1780
On Windows, renaming a directory that was just created can fail with PermissionError: [WinError 5] Access denied

PR Checklist:

[ x] All new features have been tested
[ ] All new features have been documented
[ x] I have read the CONTRIBUTING.md file
[ x] I will abide by the code of conduct

spa51273 commented 1 month ago

Russell / Russell and Malcom, Thanks so much for all your patience and guidance!

I will address all the above on this PR this weekend or early next week. Hope it's not too late. Work got backlogged for the past 7 days and unfortunately I'll need to catch up with it first...

rmartin16 commented 3 weeks ago

Just FYI: I ended up implementing the File tool in https://github.com/beeware/briefcase/pull/1871; this will save you some work in this PR but you will first either need to rebase what's here on main or merge main in to update it. Feel free to let us know if you run in to issues or have any questions.