Ensure all files are unique for check-wheel-contents

beeware / briefcase

Tools to support converting a Python project into a standalone native application.

https://briefcase.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

2.47k stars 350 forks source link

Ensure all files are unique for check-wheel-contents #1839

Closed rmartin16 closed 1 month ago

rmartin16 commented 1 month ago

Changes

hynek/build-and-inspect-python-package runs check-wheel-contents and it requires the wheel contains zero duplicated files
RE: https://github.com/beeware/.github/pull/137

PR Checklist:

[X] All new features have been tested
[X] All new features have been documented
[X] I have read the CONTRIBUTING.md file
[X] I will abide by the code of conduct

rmartin16 commented 1 month ago

fwiw, their documentation says (1) "you copied a file when you meant to rename it" or (2) "you built a wheel, renamed a file, and re-created the wheel without deleting the build directory first".

Number (2) sounds like a historical problem....but number (1) seems reasonable I guess. I'd argue, though, it is late in the process to be catching this when you're building a wheel but...