Introduce the `File` tool and tweak stub binary implementation

beeware / briefcase

Tools to support converting a Python project into a standalone native application.

https://briefcase.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

2.47k stars 350 forks source link

Introduce the `File` tool and tweak stub binary implementation #1871

Closed rmartin16 closed 3 weeks ago

rmartin16 commented 3 weeks ago

Changes

Introduce the File tool
- Encapsulates complex file operations such as archive unpacking
- Incorporates the (now removed) Download tool's functionality
Some updates to the stub binary error handling

Notes

I was making the stub binary updates while rebasing #1714....but it seems more appropriate on its own

PR Checklist:

[x] All new features have been tested
[x] All new features have been documented
[X] I have read the CONTRIBUTING.md file
[X] I will abide by the code of conduct

rmartin16 commented 3 weeks ago

ive nerdsniped myself in to implementing a File tool....

rmartin16 commented 3 weeks ago

The updates for the File tool were relatively extensive but also pretty banal. Reviewing the changes for each commit will help discern what I changed for the stub binary versus the File tool.

rmartin16 commented 3 weeks ago

A new problem from this is a corrupted build directory if the stub can't be installed.

Wasn't there work being done to ensure the bundle was deleted if the CreateCommand goes bad?