search

beeware / briefcase

Tools to support converting a Python project into a standalone native application.
https://briefcase.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
2.69k stars 375 forks source link

Make setup.py return code != 0 if a build error occurred #219

Closed rixx closed 4 years ago

rixx commented 5 years ago

Having a correct return code would be great for debugging (and to stop me from being excited seeing the 'python setup.py finished with status code 0' notification).

freakboy3742 commented 5 years ago

True - we should definitely be honoring status codes, if only for integration with larger CI systems.

In terms of actually fixing this - I suspect the solution will be a larger scale teardown. I'm starting to think that briefcase may need to move from being a distutils extension to being a standalone build tool. setup.py is really optimized for library distribution, not application distribution; and there seems to be general trend to move away from distutils towards custom build tools (see PEP518, etc).

freakboy3742 commented 4 years ago

This has been addressed in the 0.3 development branch that has just landed.