Closed MosGeo closed 2 years ago
freakboy3742
commented
2 years ago Return code 2148734720 is a DLL loading issue; that suggests that you haven't got .NET Framework 3.5 installed on your machine, which is a requirement of WiX. Can you confirm that this is installed?
Also - if you're getting a dialog that says "do you want to view information about this issue"... can you provide the detail that is provided when you say "Yes"?
MosGeo
commented
2 years ago The 'Yes' does link to repairing of .NET framework (link below). I did that and nothing changed. Also, I am able to generate MSI with briefcase 0.3.8 with no issues (tried it before posing the issue). I am assuming that they use the same wix version. So I think .NET is ok.
I will test now with completely clean Windows (in Windows Sandbox) and report back.
EDIT: @freakboy3742: So I did my test in windows sandbox (fresh machine basically). It worked without any issues. I still think something fishy is still going on as 0.3.8 is working without a hitch. I will investigate further and report back once I know the issue. I don't think anybody can help in this as the problem will not be reproducible by other people as far as I can see. Thanks!
MosGeo
commented
2 years ago @freakboy3742
I found the issue. It is related to the support package (mainly wix)
On my machine: briefcase does not download the support package automatically to the new location even though the folder does not exist so it fails with the above message. Copying the support package from 0.3.8 to the required 0.3.9 location manually, it works.
On fresh machine: briefcase notify the user about the changes and asks if they want the files to be redownloaded or moved manually. This happens everytime briefcase does not detect the support folder (e.g., if I delete it manually).
I still don't know why this is happening. I attempted to replicate my machine by installing and using 0.3.8 and then using 0.3.9 and it still worked as expected on the fresh machine.
I would note that the upgrade command does not work in both fresh or my old machine with this error but I don't think it is related.
Briefcase will upgrade the following tools:
- rcedit
- wix
Log saved to C:\Users\Mustafa\Desktop\briefcase_test\3.9 copy\briefcase.2022_08_23-08_06_22.upgrade.log
Traceback (most recent call last):
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.1776.0_x64__qbz5n2kfra8p0\lib\runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.1776.0_x64__qbz5n2kfra8p0\lib\runpy.py", line 86, in _run_code
exec(code, run_globals)
File "C:\Users\Mustafa\Desktop\briefcase_test\.venv\Scripts\briefcase.exe\__main__.py", line 7, in <module>
File "C:\Users\Mustafa\Desktop\briefcase_test\.venv\lib\site-packages\briefcase\__main__.py", line 15, in main
command(**options)
File "C:\Users\Mustafa\Desktop\briefcase_test\.venv\lib\site-packages\briefcase\commands\upgrade.py", line 120, in __call__
self.logger.info(f"Upgrading {tool.full_name}...", prefix=tool.name)
AttributeError: 'RCEdit' object has no attribute 'full_name'The RCEdit problem is definitely a bug; I've addressed that in #843.
Could I ask you to please:
briefcase upgrade wix to just upgrade WiX, and see if the problem persists.freakboy3742
commented
2 years ago Closing; The RCEdit issue has been resolved, and based on the other comments in the thread, it appears the issue may have been transient.
Describe the bug Briefcase is not able to generate the MSI for newly created project. Version 0.3.8 works but version 0.3.9 does not.
To Reproduce Steps to reproduce the behavior:
Expected behavior MSI is generated without error.
Screenshots
Environment:
Additional context Add any other context about the problem here.