search

beeware / cricket

A GUI tool for running Python test suites.
BSD 3-Clause "New" or "Revised" License
213 stars 69 forks source link

Add a cancel button on test discovery failure, so we can cleanly abort #5

Closed stephenmcd closed 11 years ago

stephenmcd commented 11 years ago

Hey Russell,

This is really cool, thanks for releasing it.

One issue I had was that I haphazardly first ran the django module in a directory without a Django project. This triggers an error dialogue with a retry button which is all well and good, but there was no obvious way to quit out of this scenario - even Ctrl C on the terminal failed and I couldn't escape without kill -9ing the process.

My change adds a cancel button to the error dialogue, which gets overridden for TestLoadErrorDialog to shut down the whole app.

Thanks again!

Steve

thsutton commented 11 years ago

Does this not lead to an error as the app ends?

_tkinter.TclError: can't invoke "toplevel" command:  application has been destroyed
stephenmcd commented 11 years ago

Yes I did receive that error, but wasn't sure how to surpress it. First time touching tkinter here :-)

thsutton commented 11 years ago

I had the same response. :-)