beeware / cricket

A GUI tool for running Python test suites.
BSD 3-Clause "New" or "Revised" License
213 stars 69 forks source link

Undefined name 'child' #80

Open cclauss opened 5 years ago

cclauss commented 5 years ago

flake8 testing of https://github.com/pybee/cricket on Python 3.7.1

$ flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics

./cricket/model.py:68:36: F821 undefined name 'child'
        self._child_nodes[label] = child
                                   ^
./cricket/model.py:70:45: F821 undefined name 'child'
        self._source._notify('remove', item=child)
                                            ^
2     F821 undefined name 'child'
2

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.