beeware / mobile-forge

A tool to manage building cross-platform binary wheels for mobile devices
BSD 3-Clause "New" or "Revised" License
20 stars 13 forks source link

Add scikit-learn recipe #16

Open serhii-vlasiuk opened 10 months ago

serhii-vlasiuk commented 10 months ago

Add scikit-learn recipe with version 1.3.1

PR Checklist:

freakboy3742 commented 10 months ago

Thanks for the contribution - but I'm unclear how you're getting this to build. It lists scipy as a host dependency... but there's no recipe for scipy. How are you building this requirement?

serhii-vlasiuk commented 10 months ago

Manually downloaded scikit_learn-1.3.1-cp311-cp311-ios_12_0_iphoneos_arm64.whl and copy to mobile-forge/dist/ directory.

freakboy3742 commented 10 months ago

I'm not sure how that's an answer to my question. Scikit-learn is dependent on scipy. If there isn't a scipy recipe, how are you getting a whl file for Scikit-learn?

If that's a typo an you meant to say a scipy wheel... where are you getting that wheel from?

serhii-vlasiuk commented 10 months ago

I downloaded scipy-1.11.3-cp312-cp312-macosx_12_0_arm64.whl and copy to mobile-forge/dist/ directory

freakboy3742 commented 10 months ago

That can't possibly work. The requirement that is specified is for a host install, so the install will be enforcing iPhone wheel tags (so - ios_12_0_iphonesimulator_arm64, etc). And, in my testing, that's exactly what happens.

[venv3.12-ios_12_0_iphonesimulator_x86_64] Install forge host requirements

Looking in links: /Users/rkm/beeware/mobile-forge/dist
ERROR: Could not find a version that satisfies the requirement scipy==1.11.3 (from versions: none)
ERROR: No matching distribution found for scipy==1.11.3
serhii-vlasiuk commented 10 months ago

Yes, For iphonesimulator it won't work.

freakboy3742 commented 10 months ago

Yes, For iphonesimulator it won't work.

Yeah - but it won't work for iphoneos either. If it won't work for iphonesimulator, and it won't work for iphoneos... in what conditions will it work?