search

beeware / toga-chart

A matplotlib charting widget for Toga.
BSD 3-Clause "New" or "Revised" License
27 stars 13 forks source link

PRs fail flake8 in CI for already existing code. #62

Closed ahonnecke closed 1 year ago

ahonnecke commented 1 year ago

Describe the bug

image

Steps to reproduce

  1. Open a PR

Expected behavior

The PR fails if the dev has introduced errors.

Screenshots

No response

Environment

Logs

 [INFO] This may take a few minutes...
check toml...............................................................Passed
check yaml...............................................................Passed
check for case conflicts.................................................Passed
check docstring is first.................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
isort....................................................................Passed
pyupgrade................................................................Passed
black....................................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

docs/conf.py:123:20: E231 missing whitespace after ':'
docs/conf.py:125:21: E231 missing whitespace after ':'

ensure-changelog.........................................................Failed
- hook id: ensure-changelog
- exit code: 3

Additional context

FWIW, this only occurs in CI. pre-commit works locally (ubuntu)

rmartin16 commented 1 year ago

Only occurs for Python 3.12. Seems like flake8==6.0.0 isn't compatible. Since the pre-commit-update workflow hasn't been working, the hooks are out of date. https://github.com/beeware/toga-chart/pull/57 is trying to fix this.

Nonetheless, using flake8==6.1.0 should fix this for Python 3.12.