Set Content When Initializing Window [Cont.]

beeware / toga

A Python native, OS native GUI toolkit.

https://toga.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

4.19k stars 656 forks source link

Set Content When Initializing Window [Cont.] #2586

Closed Cameronsplaze closed 1 month ago

Cameronsplaze commented 1 month ago

Fixes #2307

(A continuation from https://github.com/beeware/toga/pull/2314)

PR Checklist:

[x] All new features have been tested
[x] All new features have been documented
[x] I have read the CONTRIBUTING.md file
[x] I will abide by the code of conduct

Cameronsplaze commented 1 month ago

Will the doc string context changes update the ReadTheDocs? I haven't checked that on the list juuust in case.

mhsmith commented 1 month ago

Will the doc string context changes update the ReadTheDocs? I haven't checked that on the list juuust in case.

Yes: there's a readthedocs preview link at the bottom of the "checks" section below. And after the PR is merged, the changes will be made public under https://toga.readthedocs.io/en/latest/ . Note the URL says "latest" as opposed to "stable" – you can switch between them using the link at the bottom left on RTD.

Cameronsplaze commented 1 month ago

Cool, thanks! I didn't realize docs can be created on PR's, I really like that feature!

Is there anything else you'd like changed with this PR while I'm here?