beeyev / Mikrotik-RouterOS-automatic-backup-and-update

Script sends backups to email and keep your mikrotik firmware up to date.
MIT License
442 stars 83 forks source link

Mikrotik 7.12 Breaking Changes #44

Closed amp88759 closed 1 year ago

amp88759 commented 1 year ago

I think this script is great.

When the script updates 7.11.2 to 7.12 the script becomes broken because one of the commands has been renamed.

Looking at this https://forum.mikrotik.com/viewtopic.php?t=201345

It states: email - rename "address" property to "server"

Therefore to fix the script find the section of script below

#Check proper email config
:if ([:len $emailAddress] = 0 or [:len [/tool e-mail get address]] = 0 or [:len [/tool e-mail get from]] = 0) do={
    :log error ("$SMP Email configuration is not correct, please check Tools -> Email. Script stopped.");
    :error "$SMP bye!";

change the word address (after get) to server

Apply the script.

When updating from 7.11.2 to 7.12 the script failed. The routerOS was updated but the routerboard firmware was not.

I hope this helps someone!

beeyev commented 1 year ago

Thanks for finding the solution, I really appreciate it. I will make a fix asap.

amp88759 commented 1 year ago

No problem at all.

On Sat, 11 Nov 2023 at 11:35, Alexander @.***> wrote:

Thanks for finding the solution, I really appreciate it. I will make a fix asap.

— Reply to this email directly, view it on GitHub https://github.com/beeyev/Mikrotik-RouterOS-automatic-backup-and-update/issues/44#issuecomment-1806792151, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2MAIMTHPSNBHYOG7XVSAMDYD5PGLAVCNFSM6AAAAAA7HGFAMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBWG44TEMJVGE . You are receiving this because you authored the thread.Message ID: <beeyev/Mikrotik-RouterOS-automatic-backup-and-update/issues/44/1806792151 @github.com>

beeyev commented 1 year ago

Fixed, thanks for your help, mate!

amp88759 commented 1 year ago

Hi Alex

Thanks for recognising that: not a problem. My dad who’s 80 told me he didn’t get an email about ‘his router’ this morning. Plagues me to death with ‘operator error’.

This time he was right! 🤣🤣

Best wishes

Andrew

On Sat, 11 Nov 2023 at 20:00, Alexander @.***> wrote:

Fixed, thanks for your help, mate!

— Reply to this email directly, view it on GitHub https://github.com/beeyev/Mikrotik-RouterOS-automatic-backup-and-update/issues/44#issuecomment-1806904846, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2MAIMT4IOQYVLFWTAU3SP3YD7KPJAVCNFSM6AAAAAA7HGFAMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBWHEYDIOBUGY . You are receiving this because you authored the thread.Message ID: <beeyev/Mikrotik-RouterOS-automatic-backup-and-update/issues/44/1806904846 @github.com>