beeyev / thumbor-s3-docker

A docker image for thumbor with AWS S3 / Minio integration for cropping, resizing, applying filters and optimizing images on the fly.
MIT License
49 stars 10 forks source link

Add numpy library which is required for OpenCV support #14

Closed jmortlock closed 1 year ago

jmortlock commented 1 year ago

I have added Numpy which is required for various filters and dectors in thumbor. In particular for us we are using the following detectors setup

        DETECTORS:
              "['thumbor.detectors.face_detector', 'thumbor.detectors.feature_detector']",

Version range came from this PR https://github.com/thumbor/thumbor/pull/1537

beeyev commented 1 year ago

Thanks! Do you think opencv-python-headless also needs to be included?

jmortlock commented 1 year ago

I did have a look at this and I don't think it does, the reason being is that previously we have been using the docker image from this repository: https://github.com/mvhirsch/thumbor-docker/blob/f766bf614dedf4b54b84bbd3e558c7cc09c04ad4/7/alpine/Dockerfile and it does not have opencv-python-headless as an installed dependency.

If your able to get a release with this change out i would be happy to test and report back to you

beeyev commented 1 year ago

Okay, I will check it. Thanks again for the participation! 👍