search

beeyev / thumbor-s3-docker

A docker image for thumbor with AWS S3 / Minio integration for cropping, resizing, applying filters and optimizing images on the fly.
MIT License
49 stars 10 forks source link

Change the default endpoint URLs from '' to default(None) #16

Closed jmortlock closed 1 year ago

jmortlock commented 1 year ago

When using this image with S3 the default of empty '' causes the following error

2023-02-13 22:05:30 thumbor:WARNING Error while trying to get the image from the result storage: Invalid endpoint:

I believe this is because it is defaulting to '' instead of None

https://github.com/thumbor/thumbor-aws

jmortlock commented 1 year ago

Hi @beeyev if you could manage another release that would be great, each day I get a bit further i feel like its close now :)

beeyev commented 1 year ago

@jmortlock Thanks for the participation, I appreciate it a lot! Please feel free to create new PR's if you need.