Failed client tests (win32 vc10 release)

[GoogleCodeExporter]

What steps will reproduce the problem?
1. set GYP_MSVS_VERSION=2010
2. src\tools\gyp\gyp.bat --no-circular-check 
src\client\windows\breakpad_client.gyp
3. devenv.exe src\client\windows\breakpad_client.sln  /build "Release|Win32"
4. src\client\windows\Release\client_tests.exe

What is the expected output? What do you see instead?
Running main() from gmock_main.cc
[==========] Running 35 tests from 7 test cases.
[----------] Global test environment set-up.
[----------] 7 tests from ExceptionHandlerDeathTest
[ RUN      ] ExceptionHandlerDeathTest.InProcTest
[       OK ] ExceptionHandlerDeathTest.InProcTest (44 ms)
[ RUN      ] ExceptionHandlerDeathTest.OutOfProcTest
[       OK ] ExceptionHandlerDeathTest.OutOfProcTest (32 ms)
[ RUN      ] ExceptionHandlerDeathTest.InvalidParameterTest
Running main() from gmock_main.cc
exception_handler_death_test.cc(197): error: Death test: printf(0)
    Result: died but not with expected exit code:
            Exited with exit status 1
Actual msg:
[  DEATH   ] 
[  FAILED  ] ExceptionHandlerDeathTest.InvalidParameterTest (6 ms)
[ RUN      ] ExceptionHandlerDeathTest.PureVirtualCallTest
Running main() from gmock_main.cc
[       OK ] ExceptionHandlerDeathTest.PureVirtualCallTest (29 ms)
[ RUN      ] ExceptionHandlerDeathTest.InstructionPointerMemory
2013-03-06 21:13:10: minidump.cc:3833: INFO: Minidump opened minidump 
C:\Users\P-PERV~1\AppData\Local\Temp\InstructionPointerMemory\f2766d35-bd66-4cae
-a8f1-018ec0a00875.dmp
2013-03-06 21:13:10: minidump.cc:3944: INFO: Minidump not byte-swapping minidump
2013-03-06 21:13:10: minidump.cc:3805: INFO: Minidump closing minidump
[       OK ] ExceptionHandlerDeathTest.InstructionPointerMemory (28 ms)
[ RUN      ] ExceptionHandlerDeathTest.InstructionPointerMemoryMinBound
2013-03-06 21:13:10: minidump.cc:3833: INFO: Minidump opened minidump 
C:\Users\P-PERV~1\AppData\Local\Temp\InstructionPointerMemoryMinBound\5fc1bb18-3
32d-45a5-b041-47e3cf97bd05.dmp
2013-03-06 21:13:10: minidump.cc:3944: INFO: Minidump not byte-swapping minidump
2013-03-06 21:13:10: minidump.cc:3805: INFO: Minidump closing minidump
[       OK ] ExceptionHandlerDeathTest.InstructionPointerMemoryMinBound (36 ms)
[ RUN      ] ExceptionHandlerDeathTest.InstructionPointerMemoryMaxBound
2013-03-06 21:13:10: minidump.cc:3833: INFO: Minidump opened minidump 
C:\Users\P-PERV~1\AppData\Local\Temp\InstructionPointerMemoryMaxBound\3da73278-7
bf2-4e76-9863-9aa743003991.dmp
2013-03-06 21:13:10: minidump.cc:3944: INFO: Minidump not byte-swapping minidump
2013-03-06 21:13:10: minidump.cc:3805: INFO: Minidump closing minidump
[       OK ] ExceptionHandlerDeathTest.InstructionPointerMemoryMaxBound (28 ms)
[----------] 7 tests from ExceptionHandlerDeathTest (204 ms total)

[----------] 5 tests from MinidumpTest
[ RUN      ] MinidumpTest.Version
[       OK ] MinidumpTest.Version (1 ms)
[ RUN      ] MinidumpTest.Normal
[       OK ] MinidumpTest.Normal (21 ms)
[ RUN      ] MinidumpTest.SmallDump
[       OK ] MinidumpTest.SmallDump (22 ms)
[ RUN      ] MinidumpTest.LargerDump
[       OK ] MinidumpTest.LargerDump (28 ms)
[ RUN      ] MinidumpTest.FullDump
[       OK ] MinidumpTest.FullDump (78 ms)
[----------] 5 tests from MinidumpTest (150 ms total)

[----------] 5 tests from ExceptionHandlerTest
[ RUN      ] ExceptionHandlerTest.InvalidParameterMiniDumpTest
Running main() from gmock_main.cc
exception_handler_test.cc(247): error: Death test: DoCrashInvalidParameter()
    Result: died but not with expected exit code:
            Exited with exit status 1
Actual msg:
[  DEATH   ] 
exception_handler_test.cc(248): error: Value of: !dump_file.empty() && 
!full_dump_file.empty()
  Actual: false
Expected: true
[  FAILED  ] ExceptionHandlerTest.InvalidParameterMiniDumpTest (15 ms)
[ RUN      ] ExceptionHandlerTest.PureVirtualCallMiniDumpTest
Running main() from gmock_main.cc
exception_handler_test.cc(318): error: Death test: DoCrashPureVirtualCall()
    Result: died but not with expected exit code:
            Exited with exit status 1
Actual msg:
[  DEATH   ] 
exception_handler_test.cc(319): error: Value of: !dump_file.empty() && 
!full_dump_file.empty()
  Actual: false
Expected: true
[  FAILED  ] ExceptionHandlerTest.PureVirtualCallMiniDumpTest (15 ms)
[ RUN      ] ExceptionHandlerTest.WriteMinidumpTest
2013-03-06 21:13:10: minidump.cc:3833: INFO: Minidump opened minidump 
C:\Users\P-PERV~1\AppData\Local\Temp\WriteMinidumpTest\f6a12ebb-8806-4bdf-a5c0-4
c8468f80ade.dmp
2013-03-06 21:13:10: minidump.cc:3944: INFO: Minidump not byte-swapping minidump
2013-03-06 21:13:10: minidump.cc:3805: INFO: Minidump closing minidump
[       OK ] ExceptionHandlerTest.WriteMinidumpTest (21 ms)
[ RUN      ] ExceptionHandlerTest.AdditionalMemory
2013-03-06 21:13:10: minidump.cc:3833: INFO: Minidump opened minidump 
C:\Users\P-PERV~1\AppData\Local\Temp\AdditionalMemory\5b58d6af-40fa-4c52-8427-cd
ae9a734b35.dmp
2013-03-06 21:13:10: minidump.cc:3944: INFO: Minidump not byte-swapping minidump
2013-03-06 21:13:10: minidump.cc:3805: INFO: Minidump closing minidump
[       OK ] ExceptionHandlerTest.AdditionalMemory (21 ms)
[ RUN      ] ExceptionHandlerTest.AdditionalMemoryRemove
2013-03-06 21:13:10: minidump.cc:3833: INFO: Minidump opened minidump 
C:\Users\P-PERV~1\AppData\Local\Temp\AdditionalMemoryRemove\1b7c26dd-5a93-4f7a-b
0d4-58c1307ba6c9.dmp
2013-03-06 21:13:10: minidump.cc:3944: INFO: Minidump not byte-swapping minidump
2013-03-06 21:13:10: minidump.cc:2773: INFO: MinidumpMemoryList has no memory 
region at 0x460af8
2013-03-06 21:13:10: minidump.cc:3805: INFO: Minidump closing minidump
[       OK ] ExceptionHandlerTest.AdditionalMemoryRemove (20 ms)
[----------] 5 tests from ExceptionHandlerTest (92 ms total)

[----------] 2 tests from AssertDeathSanity
[ RUN      ] AssertDeathSanity.Simple
Running main() from gmock_main.cc
[       OK ] AssertDeathSanity.Simple (5 ms)
[ RUN      ] AssertDeathSanity.Regex
Running main() from gmock_main.cc
Running main() from gmock_main.cc
[       OK ] AssertDeathSanity.Regex (9 ms)
[----------] 2 tests from AssertDeathSanity (14 ms total)

[----------] 6 tests from ExceptionHandlerCallbacks
[ RUN      ] ExceptionHandlerCallbacks.FilterTrue_No_Callback
[       OK ] ExceptionHandlerCallbacks.FilterTrue_No_Callback (27 ms)
[ RUN      ] ExceptionHandlerCallbacks.FilterTrue_Callback
[       OK ] ExceptionHandlerCallbacks.FilterTrue_Callback (27 ms)
[ RUN      ] ExceptionHandlerCallbacks.FilterFalse_No_Callback
[       OK ] ExceptionHandlerCallbacks.FilterFalse_No_Callback (5 ms)
[ RUN      ] ExceptionHandlerCallbacks.FilterFalse_Callback
[       OK ] ExceptionHandlerCallbacks.FilterFalse_Callback (5 ms)
[ RUN      ] ExceptionHandlerCallbacks.No_Filter_No_Callback
[       OK ] ExceptionHandlerCallbacks.No_Filter_No_Callback (27 ms)
[ RUN      ] ExceptionHandlerCallbacks.No_Filter_Callback
[       OK ] ExceptionHandlerCallbacks.No_Filter_Callback (27 ms)
[----------] 6 tests from ExceptionHandlerCallbacks (118 ms total)

[----------] 3 tests from ExceptionHandlerNesting
[ RUN      ] ExceptionHandlerNesting.Skip_From_Inner_Filter
[       OK ] ExceptionHandlerNesting.Skip_From_Inner_Filter (28 ms)
[ RUN      ] ExceptionHandlerNesting.Skip_From_Inner_Callback
[       OK ] ExceptionHandlerNesting.Skip_From_Inner_Callback (51 ms)
[ RUN      ] ExceptionHandlerNesting.Handled_By_Inner_Handler
[       OK ] ExceptionHandlerNesting.Handled_By_Inner_Handler (28 ms)
[----------] 3 tests from ExceptionHandlerNesting (107 ms total)

[----------] 7 tests from CrashGenerationServerTest
[ RUN      ] CrashGenerationServerTest.PingServerTest
[       OK ] CrashGenerationServerTest.PingServerTest (0 ms)
[ RUN      ] CrashGenerationServerTest.InvalidRegistration
[       OK ] CrashGenerationServerTest.InvalidRegistration (1 ms)
[ RUN      ] CrashGenerationServerTest.TruncateRegistration
[       OK ] CrashGenerationServerTest.TruncateRegistration (0 ms)
[ RUN      ] CrashGenerationServerTest.CloseAfterRegistration
[       OK ] CrashGenerationServerTest.CloseAfterRegistration (1 ms)
[ RUN      ] CrashGenerationServerTest.ResponseBufferTooSmall
[       OK ] CrashGenerationServerTest.ResponseBufferTooSmall (0 ms)
[ RUN      ] CrashGenerationServerTest.CloseAfterResponse
[       OK ] CrashGenerationServerTest.CloseAfterResponse (1 ms)
[ RUN      ] CrashGenerationServerTest.SendInvalidAck
[       OK ] CrashGenerationServerTest.SendInvalidAck (0 ms)
[----------] 7 tests from CrashGenerationServerTest (3 ms total)

[----------] Global test environment tear-down
[==========] 35 tests from 7 test cases ran. (688 ms total)
[  PASSED  ] 32 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] ExceptionHandlerDeathTest.InvalidParameterTest
[  FAILED  ] ExceptionHandlerTest.InvalidParameterMiniDumpTest
[  FAILED  ] ExceptionHandlerTest.PureVirtualCallMiniDumpTest

 3 FAILED TESTS

What version of the product are you using? On what operating system?
Revision: 1125
OS: Win7 64 sp1
compiler: vc10

Please provide any additional information below.
Debug version passes all tests successfully.

Original issue reported on code.google.com by petr.per...@ovsoft.ru on 6 Mar 2013 at 5:29

[GoogleCodeExporter]

Same problem here. I'm guessing by the date that I should look for a different 
solution  for crash reporting, as no one has replied since 6th March.

Original comment by Luke.Whi...@gmail.com on 29 May 2013 at 11:14

[GoogleCodeExporter]

Can you go back from revision 1125 and see where this broke? Or perhaps it 
never worked in the first place?

Original comment by thestig@chromium.org on 29 May 2013 at 11:34

[GoogleCodeExporter]

> Can you go back from revision 1125 and see where this broke?
I'll do it on this weekend.

> Or perhaps it never worked in the first place?
i didn't use breakpad before, so i don't know.

Original comment by petr.per...@ovsoft.ru on 30 May 2013 at 8:24

[GoogleCodeExporter]

I suspect this is just an issue with the unit tests, FWIW.

Original comment by ted.mielczarek on 30 May 2013 at 11:37

[GoogleCodeExporter]

Not sure about the PureVirtualCallMiniDumpTest, but the invalid parameter 
failures are real issues.
The issue can be reproduced using the crash_generation_app sample:
1. Build in Release configuration.
2. Launch the app and start the server.
3. Launch the app again as client - and choose the Invalid Param option.
4. App crashes - nothing is sent to server.

Original comment by ron...@gmail.com on 30 May 2013 at 1:08

[GoogleCodeExporter]

ExceptionHandlerTest.PureVirtualCallMiniDumpTest broke in revision 1034.

This two are broken at least from 1019. Looks like earlier build systems 
versions doesn't support vc10.
ExceptionHandlerDeathTest.InvalidParameterTest
ExceptionHandlerTest.InvalidParameterMiniDumpTest

Original comment by petr.per...@ovsoft.ru on 3 Jun 2013 at 5:56

[GoogleCodeExporter]

If you don't change the gyp checkout, you can still use the most current 
version to generate the MSVS build files at older revisions. I went back as far 
as r600 and the behavior has always been the same for at least 
ExceptionHandlerTest.InvalidParameterMiniDumpTest - works in debug mode but 
broken in release mode.

Original comment by thestig@chromium.org on 3 Jun 2013 at 9:57