Release Build Fails due to local variables not being referenced.

[GoogleCodeExporter]

What steps will reproduce the problem?
1.Check out the latest code drop
2.Run the command gyp.bat --no-circular-check 
src\client\windows\breakpad_client.gyp
3.Open the breakpad_client.sln with visual studio 2010
4.Build solution on Release, Win32
5.Get the following error:
6>crash_generation_server.cc(391): error C2220: warning treated as error - no 
'object' file generated
6>crash_generation_server.cc(391): warning C4189: 'error_code' : local variable 
is initialized but not referenced
6>crash_generation_server.cc(471): warning C4189: 'error_code' : local variable 
is initialized but not referenced
6>crash_generation_server.cc(520): warning C4189: 'error_code' : local variable 
is initialized but not referenced

What version of the product are you using? On what operating system?
Using the latest drop from svn. Running this on Windows 7, 64-bit.

Please provide any additional information below.
I add in the #ifdef (_DEBUG) around the code DWORD error_code = success ? 
ERROR_SUCCESS : GetLastError(); to get the build to succeed.

#ifdef _DEBUG
  DWORD error_code = success ? ERROR_SUCCESS : GetLastError();
#endif // _DEBUG

or

I can change the project property to not treat warnings as errors. I would 
prefer not to change the warning levels.

Looking to see what the best option is?

Original issue reported on code.google.com by jacoble...@gmail.com on 16 Oct 2013 at 3:00

[GoogleCodeExporter]

I'm having this issue as well, which is the best in this case then?

Original comment by Ghla...@gmail.com on 27 Nov 2013 at 8:51

[GoogleCodeExporter]

Will fix...

Original comment by thestig@chromium.org on 9 Dec 2013 at 9:13

• Changed state: Started

[GoogleCodeExporter]

Thanks.

Original comment by Ghla...@gmail.com on 9 Dec 2013 at 9:28

[GoogleCodeExporter]

http://code.google.com/p/google-breakpad/source/detail?r=1249

Original comment by thestig@chromium.org on 9 Dec 2013 at 10:04

• Changed state: Fixed