`default_limit` should not attach `_limit` param to a find request

beezwax / fmrest-ruby

FileMaker Data API client for Ruby with ActiveRecord-like ORM features

MIT License

22 stars 10 forks source link

Closed Hkly closed 4 years ago

Hkly commented 4 years ago

When I have a default_limit set, it attaches the _limit param to the GET request when I try to find by record id

https://some.fm.data.base/layouts/SomeDataLayout/records/465?_limit=999999

returns the error "Unknown parameter(s): _limit", error code "960"

pilaf commented 4 years ago

@Hkly I pushed a potential fix to the branch named discard-collection-params-on-find-single

Could you try using the gem from that branch and checking if it solves the problem for you?

Here's how to use that branch from your Gemfile:

gem "fmrest", github: "beezwax/fmrest-ruby", branch: "discard-collection-params-on-find-single"

Here's a pull request in case you want to review changes: https://github.com/beezwax/fmrest-ruby/pull/36

Hkly commented 4 years ago

Thanks @pilaf! Tested it and it works!

pilaf commented 4 years ago

Included in v0.5.0 release.