search

befeleme / pyp2spec

Generate Fedora RPM spec files for Python packages
MIT License
11 stars 4 forks source link

Long due improvements #33

Closed befeleme closed 1 year ago

befeleme commented 1 year ago

Each commit deals with a one issue:

hroncok commented 1 year ago

What motivated the _prefix change? Is there a discussion I can read? Or a precedence in another similar tool? E.g. the rpmlintrc files don't have this prefix and I never considered that a problem.

befeleme commented 1 year ago

What motivated the _prefix change? Is there a discussion I can read? Or a precedence in another similar tool? E.g. the rpmlintrc files don't have this prefix and I never considered that a problem.

No written discussion happened. This is based from the feedback from @frenzymadness who was using the application with the jupyterlab stack packages and found it quite frustrating. The tool outputs two files with the same name and different suffix. Typically the next step is grabbing the sources so you'd type something along

$ spectool -g pyt<TAB>
$ spectool -g python-comic2pdf.
python-comic2pdf.conf  python-comic2pdf.spec
# choose with more <TAB>s or arrows which one to use

I figured if their names don't start with the same letters, it's be more natural to get the accurate completion. _ is an arbitrary choice.

hroncok commented 1 year ago

I don't see that problem:

[python-pip (rawhide)]$ ls python-pip.*
python-pip.rpmlintrc  python-pip.spec
[python-pip (rawhide)]$ touch python-pip.conf
[python-pip (rawhide %)]$ ls python-pip.*
python-pip.conf  python-pip.rpmlintrc  python-pip.spec
[python-pip (rawhide %)]$ spectool -g p[TAB]
[python-pip (rawhide %)]$ spectool -g python-pip.spec
befeleme commented 1 year ago

I see, this is an issue between bash and zsh completion, I just checked it. Me and Lumír are using zsh where the behaviour is different.

hroncok commented 1 year ago

spectool only has Bash completion file, not ZSH, see https://pagure.io/rpmdevtools/blob/main/f/rpmdevtools.bash-completion.in

Anyway, I don't want to block this, but the underscored config looks weird to me -- other tools don't follow this practice, so IMHO you are establishing a nonstandard and hence unexpected behavior.

befeleme commented 1 year ago

I value the feedback. I'm dropping the commit for now as I have no strong desire to create precedence that'll be weird to use among the known tools.