search

befeleme / pyp2spec

Generate Fedora RPM spec files for Python packages
MIT License
11 stars 4 forks source link

Warn if the detected license isn't a valid SPDX, don't error #47

Open befeleme opened 4 months ago

befeleme commented 4 months ago

When Copr adds a license-validate check to its repositories, pyp2spec doesn't have to be so strict in the automatic mode anymore: https://github.com/fedora-copr/copr/issues/3290

Only warning should be sufficient for the human user, whom we expect to review the generated specfile anyway.

trixirt commented 3 months ago

The fedora-review will catch these problems so it is not necessary to error out.

brianjmurrell commented 3 months ago

Clearly something needs to happen here. Waiting for upstreams to fix metadata problems in their packages before COPR will successfully build them is just unworkable. I have been waiting literally weeks (if not months) for an upstream to simply fix their SPDX licence and it's still not done, making this package unbuildable in COPR.

hroncok commented 3 months ago

You don't need to use automatic pyp2spec conversion to build the package in copr.

brianjmurrell commented 3 months ago

I do if I want to use Anitya autorebuild on it and pyp2rpm fails to build the package.

Apart from the SPDX license barf, pyp2spec builds the package fine.