No highlighting & line breaks not preserved

[peter-lyons-kehl]

Hi Bent,

Thank you for RevealJS-embed-code.

This is a minor issue (compared to the issue with markdown. I confirm that loading a file works - lovely. However, it doesn't highlight, and it doesn't preserve line breaks.

• https://peter-kehl.github.io/embedded_low_level_rust/#/15
• https://peter-kehl.github.io/embedded_low_level_rust/#/16
• https://peter-kehl.github.io/embedded_low_level_rust/#/17
• source: https://github.com/peter-kehl/embedded_low_level_rust/blob/ca0b67ddc4616dc34d758177d278e1bdcb7e12af/index.html?plain=1#L30-L51

(I use my own clone of reveal.js and of your revealjs-embed-code, both published to GitHub pages. But both are up to date, with no local changes.) Thanks in advance for any tips.

[peter-lyons-kehl]

Actually, "standard" Markdown's <code> doesn't highlight for me either. So it's most likely not specific to revealjs-embed-code. I'll investigate.

[peter-lyons-kehl]

Update: The fix is to use the following two attributes:

• <pre class="language-python" (or similar), and
• `<code class="hljs"...> (That's based on https://github.com/dafrenchyman/reveal.js-extrernal-code.)

I'll provide a pull request for README.md.

[befocken]

Hi Peter, sorry for my late reply, I was not really monitoring my GitHub or associated mailbox for some time ^^".

Indeed, as you noted correctly, the language-X class is required to display the syntax highlighting. I also used it in my presentations, but forgot to mention it in the README. I'm not sure if it could work in some cases via the automatic recognition that highlight.js provides.

I did not, however, notice an error with the line breaks (the links you provided are not valid anymore as wel). What exactly is not working there?

[l0b0]

I'm also seeing missing line breaks when using this: <pre class="language-bash"><code class="hljs" data-url="my.bash"></code></pre>. Please ignore, this was caused by some custom CSS.