Size of comic cover in Recently Viewed and Latest Added sections

[cesalo]

I'm using an 2k Android Tablet and I think I'd benefit if I could enlarge the comic covers of the these 2 sections. Is this possible or is it planned for the future?

[befora]

Hey can you post a resolution of your device so I can mock it in emulator and see how it looks.

[cesalo]

Sure, it's 2048x1536.

Thanks.

On Wed, Oct 10, 2018, 6:58 PM Seth Chhim notifications@github.com wrote:

Hey can you post a resolution of your device so I can mock it in emulator and see how it looks.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sethchhim/Kuboo/issues/44#issuecomment-428761293, or mute the thread https://github.com/notifications/unsubscribe-auth/AQFDDPxZN7vYecPoTLu0Z0LryJVglb9sks5ujnuVgaJpZM4XWeh2 .

[befora]

I found the offending line mainActivity.isHiDpi() returns false when should be true. This resulted in a smaller RECENT items, leaving an empty space in the bottom. The condition for HiDpi is 2560 min value but I will lower it to 2048. This fixes your issue but I hope it doesn't break anyone else's.

[cesalo]

Excellent news .. thanks.

[befora]

I uploaded the fix to the beta channel and it is live in version 1.1.4_beta3. If you are interested in checking it out, you can opt-in to the beta at the play store app page.

[cesalo]

Thanks looks better. Appreciate the quick fix.

On Fri, Oct 12, 2018, 10:34 PM Seth Chhim notifications@github.com wrote:

I uploaded the fix to the beta channel and it is live in version 1.1.4_beta3. If you are interested in checking it out, you can opt-in to the beta at the play store app page.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sethchhim/Kuboo/issues/44#issuecomment-429504446, or mute the thread https://github.com/notifications/unsubscribe-auth/AQFDDDCIJQBc5u4kQoK3CwoU0lU3sYayks5ukVEogaJpZM4XWeh2 .

[cesalo]

Hi @sethchhim - I've changed to a Pixel Slate (3000x2000 - 293 ppi) and the Home section is using around 65% of the screen (portrait or landscape). Even before, in my previous tablet, there was still an empty space. Is there a way to fix this but maybe do it with a customizable option?

[cesalo]

This is a screenshot of how it looks:

[befora]

fixed 8769d7d1b3e41594bb79c4489dbc6f5c1c0cb1a2

Good bug report, I never did test on resolutions that high. Fixed in 1.1.8, it is uploaded and awaiting approval from Google so maybe an hour or so.

[cesalo]

Thanks it's definitely better but still if that extra 10% of the screen could be used it would be even better.

[befora]

My emulator at 3000x2000 shows full screen is used. I will investigate tomorrow.

[befora]

Did you change your thumbnail size on server? I think yours might be smaller than default, thats why it looks like that. Mine is 160x230 and it fits the entire screen.

[cesalo]

I made the change to the default, will confirm if is fixed. Thanks.

[befora]

Don't forget to clear your client cache or it will look the same.

[cesalo]

Fixed it. Thanks a lot.

[befora]

I had to revert the changes. Instead of hardcoding the height, I wrote an option to adjust it manually. There are too many devices with different sizes to get it right with a single value.

Settings -> Advanced -> Recently Viewed Height Offset

To achieve your current setting, you will need to change it from Default (+0%) to +13%

This option is available in 1.1.9 in the BETA channel and will be pushed to release after positive feedback.

[cesalo]

Thanks for the heads up. Since you added this option, I think an additional option(s) to setup the relative size of the "Recently Viewed" and "Latest Added" sections would be very helpful. I found that the "Latest Added" section is extremely small in comparison with the "Recently Viewed". I'd prefer a 60/40 ratio, at the moment is more like a 90/10.

[befora]

This is intended, I want to add many more rows in the future and have recently viewed be the "feature". It won't hurt to add another option though so I will add it later, won't be too hard. Gonna focus on server development for a week or two though.

[cesalo]

Got it and thanks. Btw - I think is awesome that you will release your version of a comic server. Great job.