search

befora / Kuboo

Kotlin + Ubooquity = Kuboo
Apache License 2.0
84 stars 41 forks source link

Home layout weird on 18:9 phones #56

Closed alfablac closed 5 years ago

alfablac commented 5 years ago

Home layout on 1.1.8 looks weird on my 18:9 Xiaomi phone (1080x2160). Recently viewed only shows about a quarter of a big cover. I have to slide through the screen to see other options. I guess it's due to this strange resolution. Maybe a custom setting to fix this (Better than treating every resolution, I dunno).

befora commented 5 years ago

Was the previous size ok for you? If so I will revert and add an "offset" option instead of hardcoding it.

befora commented 5 years ago

fixed cc2026a189fa540a9968051ea264cc0a72aab229

You can find the new setting at Settings -> Advanced -> Recently Viewed Height Offset. The larger the percentage you set, the larger the Recently Viewed item will be, so it might take some experimentation to get it right.

I have uploaded version 1.1.9 to the BETA channel. If you give me the thumbs up, I will push it to the release channel.

alfablac commented 5 years ago

I couldn't install the -release one (it fails to install.. no idea why) so I tried the -debug package and it installed. The changes worked great for me. I was getting a huge cover in the home screen lol The old layout was ok, but the custom setting feels better IMO.

Thanks for responding to the issue so fast!

befora commented 5 years ago

I looked into it and the problem was I built the apk without signing it. Unsigned apk's only work on emulator environment so I signed it with a debug key and now it works. Re-uploaded to the releases section. Please close if this solves your problem.