search

begonavizcaino / ee417-groupD

0 stars 0 forks source link

Connection feature #5

Closed EtienneDx closed 3 years ago

EtienneDx commented 3 years ago

This change contains the conenction, signup and disconnect feature, as discussed in #3 and #4. I added some placeholder jsp code to give a base on which the html & css team can start working. PS: the database connection info is in src/db/Database.java, top of the file. PPS: I included the sql code in database.ql to create the table and insert two test rows : 'test' 'test' and 'admin' 'admin'

EtienneDx commented 3 years ago

@zoujiahuan don't worry about the revert, it's done and unless someone opposes we can work our way from there edit: I'm saying it since I saw you create a branch named revert-5-feature-db

zoujiahuan commented 3 years ago

Great. As I have no experience about pull request, I just thought maybe we should merge after we all confirm the commitment.

------------------ 原始邮件 ------------------ 发件人: "begonavizcaino/ee417-groupD" @.>; 发送时间: 2021年4月4日(星期天) 下午4:19 @.>; 抄送: "星火、| @.**@.>; 主题: Re: [begonavizcaino/ee417-groupD] Connection feature (#5)

@zoujiahuan don't worry about the revert, it's done and unless someone opposes we can work our way from there

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

EtienneDx commented 3 years ago

That was the initial plan but since there's nothing else this code might mess with it's not such a problem for now. I agree that in the future we should try to have multiple persons validate before we merge, but I feel like it's fine this time