begriffs / css-ratiocinator

because your CSS is garbage
MIT License
1.04k stars 49 forks source link

New version is very different from original #24

Closed zenspider closed 11 years ago

zenspider commented 11 years ago

Before bothering to install phantomjs and everything, I tried the bookmarklet on one of my sites and the end-result had vastly different fonts and layout. I don't know what else I can do to try to reduce this problem for you. The page in question is http://seattlerb.org/

begriffs commented 11 years ago

Thanks, that's a useful example -- not too huge, but with lots of original css. I'll take a look this Friday and try to improve the ratiocinated results.

zenspider commented 11 years ago

Thanks!

begriffs commented 11 years ago

Looking into it, it seems like solving issue #8 will go a long way to improving the results on seattlerb. The program could do a third pass on the styles and look up attributes in the original CSS because the computed style irreversibly loses some information.

The third pass seems feasible though, and won't compromise the cleanliness of the result.

begriffs commented 11 years ago

I made some changes. Grab the new ratiocinator code and try again.

zenspider commented 11 years ago

While better... that's still vastly different. Maybe it is the bookmarklet and the side-by-side view?