search

begriffs / css-ratiocinator

because your CSS is garbage
MIT License
1.03k stars 49 forks source link

don't include vendor code in repsotory #34

Open losingkeys opened 11 years ago

losingkeys commented 11 years ago

Shouldn't vendor code (e.g. the stuff at vendor/phantom-jasmine/) be a submodule (if you just want the code) or listed in package.json (if you want it installable via npm)?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

begriffs commented 11 years ago

Good point. I wonder how this will work in csstrashman. That site includes ratiocinator as a submodule which heroku pulls in on deploy. Will a submodule inside a submodule work OK?

I don't know much about npm, perhaps it's the right solution for this dependency stuff. While I'm thinking about it, the functions in lib/css.js might be exposed better in an npm-style export than the way they are currently exposed by being added to the window object.

losingkeys commented 11 years ago

I don't understand, why do you want to nest them?