search

begriffs / css-ratiocinator

because your CSS is garbage
MIT License
1.03k stars 49 forks source link

be quiet by default #35

Closed losingkeys closed 11 years ago

losingkeys commented 11 years ago

don't output debugging information by default, that way the output of this tool can be piped around without stripping out extra information first.

to do this I had to add the ability to process arguments. to do THAT I added underscore to ratiocinate.js, so the 'require' line will need to be upgraded when underscore is updated/moved. There might be a more desirable way to do this.

as a final note, the verbose option is brittle because verbose needs to be considered when logging information out (are we logging output or messages?). I was going to fix this by unifying logging under a 'lib/log.js' file, or by overriding console.log, but this change seemed to be the smallest, so I opted for it instead :)

begriffs commented 11 years ago

Can you double check that the new code passes the linter at http://www.jslint.com/ ?

I've been using Crockford's linting conventions thus far.

losingkeys commented 11 years ago

he doesn't like my use of &&: "Expected an assignment or function call and instead saw an expression.". Do you want me to change that so it passes his validation or add something to the header so jslint doesn't complain?