switch to jshint

[losingkeys]

reasons:

• jshint has more options
• jshint's options are well documented, with examples
  • see: http://www.jshint.com/docs/#options
• jshint differentiates between warnings and errors (not sure if jshint doesn't do this, or I'm just not sure how to set it. looking at http://www.jslint.com/lint.html I'm thinking jslint doesn't support warnings vs errors)
  • NOTE: for vim you can get https://github.com/scrooloose/syntastic which will show you both for linted files
• jshint supports a directory-specific .jshintrc options, in addition to a .jshintignore file
  • this could save some typing, though we would probably still need to leave the /* global */ comments in there as they appear to be file-specific
  • more info no the options page: http://www.jshint.com/docs/#options

NOTE: The 'jslint' comments at the top are now moved into a project-specific '.jshintrc' json file. The global comments can still be used to identify external variables in each script, with the only difference being browser: true in '.jshintrc' may be a little different than browser: true in the jslint comments (they both define a list of globals specific to the browser iiuc), but this wasn't an issue for any of the files I've updated (those with 'jslint' comments).

NOTE: I've checked the changed files, and they all (with a small change to the indentation in lib/css.js) pass without warnings or errors.

As a final note, I've changed '.travis.yml' so it should still test the javascript files for compliance w/jshint

[begriffs]

This is interesting. I like that you can make a jshint config for the whole project.

On the other hand, one thing I like about jslint is that it is very strict. It doesn't tolerate much variation in syntax and everything is an error. I feel like it might force a more consistent style from contributors, even if that style is a little odd at times.

Check out this answer on stack overflow: http://stackoverflow.com/a/10763615

Do you think jshint's options allow you to crank up the strictness beyond jslint? The stricter the linter the more coherent the style.

[losingkeys]

I think you could crank up the strictness on jshint; if you're looking for something specific the options would probably help. This was mostly me learning about linters in javascript, but I ended up liking jshint because of the reasons above. Another thing to consider is the communities surrounding the two tools. Have a look at the jslint and jshint repositories for more info. Finally, if you like jslint, don't switch; It's not like I'm going to check in code that doesn't comply w/whatever you choose just because I would've chosen a different tool. I won't be sad if you close as 'WFM/WONTFIX' :P

[losingkeys]

Cheers, remember to crank up the strictness to your liking!

[begriffs]

It cranks up pretty well actually. (e0f36d2287918cfbe0d77504df75f048d55060da) Found some cruft that jslint had missed.

I'm glad you pushed me to use jshint.

[losingkeys]

I'm glad you like it. Note that you can have a "globals": {} object in your .jshintrc if you have some globals that will appear in all files. Alternatively you can use predefined sets of globlas (like in jslint), which don't go in the globals array, like "jQuery": true. Or you can keep em per-file, which is kind of an ok header.