Document minimum required PostgreSQL version

begriffs / pg_rational

Precise fractional arithmetic for PostgreSQL

MIT License

238 stars 14 forks source link

Document minimum required PostgreSQL version #17

Closed df7cb closed 4 years ago

df7cb commented 4 years ago

We need at least PG11 where common/int.h was introduced.

begriffs commented 4 years ago

Did int.h go by a different name in previous versions? Perhaps we could do conditional compilation of the name based on pg version?

df7cb commented 4 years ago

It contains the new safe overflow detection functions which you are using in the security fix. If you add #ifdefs, the code would be back to the old state on the older versions. (Judging from a 10s-read of the header files yesterday.)

begriffs commented 4 years ago

Would you be willing to try to add the ifdef changes in this pull request so that it can compile with more versions of pg?

df7cb commented 4 years ago

You should enable CI tests to answer that question, see #19

Results for the master branch are here: https://travis-ci.org/credativ/pg_rational Branches/Pull requests will be automatically tests if they contain the .travis-ci.yml file.

begriffs commented 4 years ago

Merged another PR which hopefully resolves this one.