behave-contrib / behave-html-formatter

HTML formatter for Behave
https://pypi.org/project/behave-html-formatter/
GNU General Public License v3.0
7 stars 10 forks source link

Maintain styles and JavaScript as external files #10

Closed bittner closed 3 years ago

bittner commented 3 years ago

Maintaining CSS and JavaScript as external files should improve maintainability.

Fixes #1

bittner commented 3 years ago

I'd like to have acceptance tests running before we merge this change (see #9). This way we should be able to prove that no existing feature breaks.

bittner commented 3 years ago

The newly introduced tests (#9 and #19) were useful to make sure that the refactoring could happen without breaking existing functionality.

All tests now pass again, only checks fail on the behave_html_formatter.html module. They're most likely straightforward to fix, but I'd prefer @schidlo to address them as you know the code better to understand their consequences.

Hence, merging. :rocket: