search

behave-contrib / behave-html-formatter

HTML formatter for Behave
https://pypi.org/project/behave-html-formatter/
GNU General Public License v3.0
7 stars 10 forks source link

Sync with pip #30

Closed fpokryvk closed 2 years ago

fpokryvk commented 2 years ago

There are several minor changes and fixes. Please review per commit.

We should sync this with pip, since it diverges now.

bittner commented 2 years ago

Looks good to me!

Please fix the tests. I think it's the removed pretty-printing that makes the HTML output different now.

Could you also try to make Flake8 pass? The complaints are most likely not from your changes, but it would be a shame to merge with a failing check. – Pylint complaints are harder to fix. We need to work on them separately, for sure.

fpokryvk commented 2 years ago

Thank you for positive review, I will try to make the tests pass. It might take some time however.

bittner commented 2 years ago

I will try to make the tests pass. It might take some time however.

It should be easy to fix them. I guess, you only need to collapse the verbatim output in the feature files.

fpokryvk commented 2 years ago

I have fixed nearly all linter errors, the remaining I have allowed in tox.ini. Also, unit test is adjusted.

fpokryvk commented 2 years ago

If you would like to have commits reorganized (e.g. disable pretty HTML and fix the test in the same commit), I can do that (if we want that change easily revertable).

fpokryvk commented 2 years ago

I see some pypy3 fails, I have no idea what it is, did I break something by these changes?

bittner commented 2 years ago

Great job so far! My compliments! :+1:

I see some pypy3 fails, I have no idea what it is, did I break something by these changes?

The error says, both for macOS and Windows, "PyPy 3.6 not found".

I don't think you broke anything. The references "macos-latest" and "windows-latest" likely pull in an image that doesn't have PyPy 3.6 installed anymore. It looks like the new images support PyPy 3.7, 3.8, 3.9.

I would propose we directly jump on PyPy 3.9. Can you adjust that?

References (Actions docs)

bittner commented 2 years ago

If you would like to have commits reorganized (e.g. disable pretty HTML and fix the test in the same commit), I can do that (if we want that change easily revertable).

Your commits make sense. IMO, they can stay like they are.

fpokryvk commented 2 years ago

All green! Finally I found out the correct combination of pypy3.9, pypy-3.9 and pypy39 in config file :) Feel free to merge and create pip package. Thanks!