search

behave-contrib / behave-html-formatter

HTML formatter for Behave
https://pypi.org/project/behave-html-formatter/
GNU General Public License v3.0
7 stars 10 forks source link

Continue to support Python 3.6, run tests against 3.10 and 3.11 #34

Closed bittner closed 1 year ago

bittner commented 1 year ago

GitHub's Azure-based infrastructure offers only newer, officially supported Python versions on the current LTS release (ubuntu-latest).

For a list of supported OS + Python combinations see:

While we're at making changes, we modernize the setup by moving tool configuration to pyproject.toml and by activating color output of Python tools on GHA. We also add Black and isort to make the pipeline setup more complete.

Related: https://github.com/behave-contrib/behave-html-pretty-formatter/issues/4

fpokryvk commented 1 year ago

Is it a good idea to drop python 3.6 completely? I've read issue [1] about python3.6 support in github, it is not available on 22.04, but 20.04 has py3.6 and ubuntu 20.04 should be supported for a long time. I would rather keep python 3.6 checks, so we do not accidentally stop supporting python 3.6 by some newer code (python 3.6 is default in other stable distributions, like RHEL 8 or CentOS 8 stream).

[1] https://github.com/actions/setup-python/issues/544

bittner commented 1 year ago

Sure, I agree. If it doesn't make things a lot more complicated, why not! Especially with test tools.

Interestingly, older Pythons work in other projects of mine without special provisions. I'll give it a try!

bittner commented 1 year ago

GitHub started migrating their runners only 4 days ago. We need to stick with Ubuntu 20.04 now, then we're good.

bittner commented 1 year ago

My comment about minify is not that important, changes looks good to me, thanks for 3.6 support, feel free to merge.

You must approve the PR (again). I cannot merge otherwise.

bittner commented 1 year ago

Let me know if you need help for https://github.com/behave-contrib/behave-html-pretty-formatter/issues/4. :rocket:

fpokryvk commented 1 year ago

I have no idea what created that, and I did not have time to study it yet. Mabye @modehnal knows, however if you know how to configure that correctly, we would appreciate your help. Thanks.