search

behave / behave-django

Behave BDD integration for Django
https://behave-django.readthedocs.io/
MIT License
205 stars 46 forks source link

Adds ability to override the django runner class #130

Closed kingbuzzman closed 2 years ago

kingbuzzman commented 2 years ago

Addresses issue: https://github.com/behave/behave-django/issues/122 Replaces: https://github.com/behave/behave-django/pull/125

kingbuzzman commented 2 years ago

@bittner Still have 2 outstanding issues:

bittner commented 2 years ago

Don't worry about Travis CI. I'll replace that by GitHub Actions tonight.

As for the Behave release, we have a much bigger problem: Only @jenisys can issue releases to PyPI, and it's unclear why he's waiting so long for it. (In the past this was all about Windows compatibility, but now ... not sure.)

Maybe you could (try to detect the Behave version and) abort execution when the feature is not supported, because the installed Behave package is not new enough?

bittner commented 2 years ago

The migration from Travis CI to GitHub Actions is now complete. I also added isort as a pipeline job to enforce more code style. The changes are merged into the main branch (yes, main not master; I also switched the default branch).

You need to fix a minor conflict in the behave management command module now due to changes on the imports, I suppose. Sorry for the inconvenience! – Looking forward to a rebased PR that I could merge. :eyes: :100:

kingbuzzman commented 2 years ago

@bittner looks like my workflow is stuck in limbo awaiting your approval ;)

kingbuzzman commented 2 years ago

@bittner I "fixed" the requirement issue, I still don't like that 1.2.7 hasn't been released, but at least tox doesn't have an issue with it anymore. Don't know what you want/can to do about it... The remaining issue now is the CI not running.

kingbuzzman commented 2 years ago

Well I would say it's "ready", my only concern is the requirements.txt, I suppose it's easy enough to create another PR to address it later on... balls on your court, chief ;) .

bittner commented 2 years ago

Ooops! What seems to be missing, actually, is updating the documentation. Can you add the option to the configuration chapter? With a few words of which problem it solves and how it is meant to be used.

In the end, would you mind squashing all the changes, so that I can merge one (or two) pristine commit(s) bearing your name? Or should I simply let GitHub do the squashing?

kingbuzzman commented 2 years ago

What seems to be missing, actually, is updating the documentation. Can you add the option to the configuration chapter? With a few words of which problem it solves and how it is meant to be used.

on it

In the end, would you mind squashing all the changes, so that I can merge one (or two) pristine commit(s) bearing your name? Or should I simply let GitHub do the squashing?

I like the squashing option better.

bittner commented 2 years ago

Well I would say it's "ready", my only concern is the requirements.txt, I suppose it's easy enough to create another PR to address it later on... balls on your court, chief ;) .

I'll take the opportunity to go down the stony way of trying to convince @jenisys to push a new release to PyPI. This is dangerous as it could keep this project trapped in the state that Behave is in for years now. But, in the end, behave-django is just a development tool, isn't it? We can easily leave the dependency on the development version of Behave. As long as we want.

What do you think? Any other thoughts?

kingbuzzman commented 2 years ago

Well I would say it's "ready", my only concern is the requirements.txt, I suppose it's easy enough to create another PR to address it later on... balls on your court, chief ;) .

I'll take the opportunity to go down the stony way of trying to convince @jenisys to push a new release to PyPI. This is dangerous as it could keep this project trapped in the state that Behave is in for years now. But, in the end, behave-django is just a development tool, isn't it? We can easily leave the dependency on the development version of Behave. As long as we want.

What do you think? Any other thoughts?

I agree with everything you just said 👍

kingbuzzman commented 2 years ago

@bittner ..why do you have to accept every CI commit now? Is there a way you can set it to run always? Are you charged per CI task?

bittner commented 2 years ago

@bittner ..why do you have to accept every CI commit now? Is there a way you can set it to run always? Are you charged per CI task?

I think this is just as long as I haven't merged "your first contribution". This sounds silly, because you have contributed a lot, I feel, but GitHub has no evidence (no commit from you in the code base) yet. Don't worry, we're about to fix that, too.

kingbuzzman commented 2 years ago

Very nice. Thank you @bittner

bittner commented 2 years ago

Thank you so much, @kingbuzzman! :1st_place_medal: :100: :trophy:

As a bonus you get free, automatic CI runs for all your changes with your next PRs!! :smirk:

bittner commented 2 years ago

BTW, have you seen #129? Maybe you want to "apply"? :nerd_face: :smiley:

I would appreciate that. Dead seriously.

kingbuzzman commented 2 years ago

I did see it, I wouldn't mind as a soft/light co-maintainer