search

behaviorbot / sentiment-bot

Replies to toxic comments with a maintainer designated reply and a link to the repo's code of conduct
https://github.com/apps/sentiment-bot
MIT License
83 stars 12 forks source link

Add COC check for name and url properties #15

Closed jamesmacfie closed 6 years ago

jamesmacfie commented 6 years ago

Fixes issue #12

@hiimbex I'm pretty much going off your guidance as per the issue for this.

This should be ok - if the check for codeOfConduct is truthy only then will it check the name and/or url properties aswell so we won't get any "can't read x of undefined" errors or anything like that.

I did try looking at the Github issue you linked to but I'm guessing that's a private repo as I can't access it ;)

update-docs[bot] commented 6 years ago

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.

welcome[bot] commented 6 years ago

Thanks so much for opening your first PR here!

welcome[bot] commented 6 years ago

Congrats on merging your first pull request here! :tada: How awesome!