search

behaviorbot / sentiment-bot

Replies to toxic comments with a maintainer designated reply and a link to the repo's code of conduct
https://github.com/apps/sentiment-bot
MIT License
83 stars 12 forks source link

Permission for team mentions? #17

Closed bkeepers closed 6 years ago

bkeepers commented 7 years ago

You can see from the comment posted in https://github.com/probot/probot/issues/258#issuecomment-345766584 that the bot currently can't mention teams. As discussed in https://github.com/probot/probot/issues/337, the app needs Read permission on Organization members.

What do you think about adding that to the app's permissions? I'm not thrilled that it's necessary, but I imagine this bot will often be used to mention teams.

welcome[bot] commented 7 years ago

Thanks for opening this issue, a maintainer will get back to you shortly!

hiimbex commented 7 years ago

I had the exact same reaction. I was gonna add the permission and a short note in the readme explaining its necessity. I agree it's worthwhile for the potential use case. It's also not that dangerous of a permission.