Use perspective-api-client and improve tests

behaviorbot / sentiment-bot

Replies to toxic comments with a maintainer designated reply and a link to the repo's code of conduct

https://github.com/apps/sentiment-bot

MIT License

83 stars 12 forks source link

Use perspective-api-client and improve tests #18

Closed sloria closed 6 years ago

sloria commented 6 years ago

Use a client library, perspective-api-client, to simplify the codebase
This makes it simpler to mock Perspective API responses. The tests now test that GitHub comments are or are not made based on the toxicity score returned by Perspective.
Prevent an error when sending comments with > 3000 characters

welcome[bot] commented 6 years ago

Thanks so much for opening your first PR here!

update-docs[bot] commented 6 years ago

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.

welcome[bot] commented 6 years ago

Congrats on merging your first pull request here! :tada: How awesome!

sloria commented 6 years ago

Thanks @hiimbex for reviewing and merging. I'm making a few improvements to the client. I'll send a PR upgrading it soon.