search

behaviorbot / sentiment-bot

Replies to toxic comments with a maintainer designated reply and a link to the repo's code of conduct
https://github.com/apps/sentiment-bot
MIT License
83 stars 12 forks source link

Remove usage of `scarlet-witch-preview` #30

Closed antn closed 3 years ago

antn commented 3 years ago

Hey there @hiimbex 👋! I'm from the Communities team at GitHub.

Unfortunately, we're going to be deprecating the scarlet-witch-preview API preview soon, and the old code_of_conduct response on the repo object will be 💀 . Your bot seems to be the 2nd biggest user of this preview!

This PR moves the bot to fetching the code_of_conduct_file field from the community profile API instead, which is what we're recommending folks use going forward. Please note that there is a bit of a change from this – forks and private repos won't have the code of conduct included in the bot's comment, since the community profile isn't accessible for these repos. Sorry about that :cry:.

Let me know if you have any questions or if I can clarify anything!

welcome[bot] commented 3 years ago

Thanks so much for opening your first PR here!

gr2m commented 3 years ago

I can also help reviewing and merging the changes, but I'm not 100% sure about the deployment setup. I think it's deployed to GitHub's Heroku Account, can you verify that the app is no longer using the preview a few minutes after the merge?

welcome[bot] commented 3 years ago

Congrats on merging your first pull request here! :tada: How awesome!

antn commented 3 years ago

@gr2m thanks for merging! It looks like we're still seeing requests coming in with the preview header - so maybe it hasn't deployed after merging?

antn commented 3 years ago

Ah, this does appear to be in the GitHub Heroku account, which I have read access to, but judging by this banner, we'll have to do some stuff first to be able to deploy it:

Screen Shot 2021-09-06 at 7 38 07 PM

I'll see if I can get access to configure the app in Heroku and get this deployed.

antn commented 3 years ago

I was able to upgrade the Heroku stack and do a manual deploy, so this PR should be resolved. I'm working on getting automatic deploys set up so we don't run into this in the future, but we should be good for now! 👍

gr2m commented 3 years ago

great, thank you!