search

behaviorbot / update-docs

Prompts users to include documentation in pull requests
https://github.com/apps/update-docs
MIT License
32 stars 9 forks source link

Enable people to specify their own documentation/required files. #10

Closed hakusaro closed 6 years ago

hakusaro commented 6 years ago

Currently, this probot has hardcoded requirements that either a README or a docs/ are modified for the notification to not trigger. Because projects have varying standards on what they name their documentation or where changes need to go on each pull request, this doesn't work in all situations.

This pull request adds a config option called updateDocsTargetFiles that allows someone to optionally configure different paths to check for docs updates on. It also modifies the tests to pass (because we now get repo content 100% of the time as opposed to only if docs aren't modified).

welcome[bot] commented 6 years ago

Thanks so much for opening your first PR here!

welcome[bot] commented 6 years ago

Congrats on merging your first pull request here! :tada: How awesome!

hiimbex commented 6 years ago

Thanks!

hakusaro commented 6 years ago

!! You're welcome @hiimbex! Probot is love, probot is life!