search

behaviorbot / update-docs

Prompts users to include documentation in pull requests
https://github.com/apps/update-docs
MIT License
32 stars 9 forks source link

Fix wrong filepath in test code #11

Closed KengoTODA closed 6 years ago

KengoTODA commented 6 years ago

test/index.js contains two patterns of file path:

  1. which starts with /
  2. which does not start with /

I guess 1 is wrong (or current implementation cannot treat README.md as document), is it true?

Sorry to say but official document of github api does not provide example output, and I haven't confirmed that actual output starts with / or not.

I want to confirm this with you first, before I propose another PR to treat CHANGELOG.md as document.

welcome[bot] commented 6 years ago

Thanks so much for opening your first PR here!

update-docs[bot] commented 6 years ago

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.

KengoTODA commented 6 years ago

Thanks bot, but this PR introduces nothing new.

KengoTODA commented 6 years ago

@hiimbex could you check?

welcome[bot] commented 6 years ago

Congrats on merging your first pull request here! :tada: How awesome!

hiimbex commented 6 years ago

wow, so sorry for the delay, I completely missed this. Thanks!