search

behaviorbot / update-docs

Prompts users to include documentation in pull requests
https://github.com/apps/update-docs
MIT License
32 stars 9 forks source link

Update update-docs to require Probot v7.2.0 #12

Closed shermanhui closed 5 years ago

shermanhui commented 5 years ago

Update behaviorbot/update-docs to use Probot v7.2.0 as per issue Updating Probot #15

I removed this line from the test file as I don't think it should belong in that assert.

expect(github.repos.getContent).toNotHaveBeenCalled()

The test below it seems to be testing for a similar case and doesn't expect github.repos.getContent not to be called. Additionally, after removing that expect, the tests passed! 😄 Please let me know if that's wrong and I can dig deeper into the issue!

welcome[bot] commented 5 years ago

Thanks so much for opening your first PR here!

update-docs[bot] commented 5 years ago

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.

shermanhui commented 5 years ago

Hi @hiimbex I've made the requested changes!

welcome[bot] commented 5 years ago

Congrats on merging your first pull request here! :tada: How awesome!

hiimbex commented 5 years ago

Thanks @shui91!