search

behaviorbot / update-docs

Prompts users to include documentation in pull requests
https://github.com/apps/update-docs
MIT License
32 stars 9 forks source link

Is this hosted? #13

Closed allanchau closed 5 years ago

allanchau commented 5 years ago

I installed the app, but the bot doesn't seem to be running. Do I need to create my own app and deploy it?

welcome[bot] commented 5 years ago

Thanks for opening this issue, a maintainer will get back to you shortly!

hiimbex commented 5 years ago

Hi @allanchau! It looks to be working to me! See: https://github.com/behaviorbot/update-docs/pull/14

Did you add your comment content's to a .github/config.yml file like so: https://github.com/behaviorbot/update-docs/blob/828f8cfa99a7f17a70287fe76a1941c5e23592bd/.github/config.yml#L6-L7

If you don't specify comment contents, the bot won't run.

allanchau commented 5 years ago

Strange, that is definitely there and merged into master. I made a new PR with changes to the .github folder only, perhaps that is why it didn't run?

hiimbex commented 5 years ago

Do you have a link to the pr?

allanchau commented 5 years ago

Sorry, it is a private repo. This is the config.yml if that helps

updateDocsComment: >
  Oops, did you forget to update the documentation?
updateDocsTargetFiles:
  - CHANGELOG
  - README
  - docs/
hiimbex commented 5 years ago

Welp, that's my bad! I just sent out a permissions update so the app will work for private repos. It should work after you accept that :)

allanchau commented 5 years ago

@hiimbex Seems it still isn't working for me 😢. I also tried it on a public repo https://github.com/idearium/idearium-lib/pull/64/files Does it need to be on master before it will start working?

hiimbex commented 5 years ago

Yea it needs to be on master.