search

behaviorbot / welcome

A probot app that welcome new users
https://github.com/apps/welcome
MIT License
198 stars 66 forks source link

I got welcomed for my first issue, but it wasn't my first issue #12

Open nornagon opened 6 years ago

nornagon commented 6 years ago

https://github.com/electron/electron/issues/13969#issuecomment-411127883

Previously, https://github.com/electron/electron/issues/12631

hiimbex commented 6 years ago

Thanks for the issue @nornagon. I actually had another report of this in the electron org a while back, and I wonder if the GH API is struggling with the volume of issues there?? I can't think of an issue on this app's end honestly. The code for the app is really simple: https://github.com/behaviorbot/new-issue-welcome/blob/master/index.js

Maybe that you created the issue from a project board somehow made things weird?

Anyways, I'll leave this issue to track any other repeats of this, but can't think of an immediate solution

zeke commented 5 years ago

Happened again! https://github.com/electron/electron/issues/14679

hiimbex commented 5 years ago

Aha! I thought it was odd the 2 people who reported this were high volume contributors.

Currently the code filters out PRs, but doesn't iterate through pages of results. But you could have a page of 29 PRs and 1 issue but have other issues in older pages.

The solution is to update the code to use the search API to get a more accurate query. I actually do this in one of the three welcomes:

const res = await context.github.search.issues({q: `is:pr is:merged author:${creator} repo:${owner}/${repo}`})

But not the other two 🤷‍♀️

Thanks for reporting this! I'll put it on my to-do list :)

MarshallOfSound commented 5 years ago

This happened to me last week as well, should have reported it 😄

nornagon commented 5 years ago

Got my third first issue today! https://github.com/electron/electron/issues/15253#issuecomment-431118457

Temerold commented 2 years ago

It seems that this only happens when the other issues have been deleted, making the new one your only -- "first" -- PR or issue. Supply more data if this doesn't appear to be the case.

nornagon commented 2 years ago

@Temerold electron/electron#15253 very much wasn't my only non-deleted issue on electron/electron at the time I created it.

Temerold commented 2 years ago

Weird... Edit: Sorry! Didn't read hiimbex's reply.

astrojuanlu commented 2 years ago

This happens to us in https://github.com/orchest/orchest/ from time to time as well. For example:

Do you have any idea what might be happening here? This is our config.