search

beingmohit / browser-playerctl

:headphones: Implements MPRIS interface for chrome
28 stars 8 forks source link

Can't Raise via MPRIS #1

Open JasonLG1979 opened 5 years ago

JasonLG1979 commented 5 years ago

1st let me say I love the idea of a MPRIS browser extension.

I've tested your extension against my GNOME Shell extension and it seems to work rather well with the exception that you can't raise the player (the browser in this case) because you set CanRasie to false and don't have a Raise method.

It would be awesome if raising would raise the browser and switch to the appropriate tab.

It would be also nice if your extension downloaded the fav icon of the "players" to ~/.local/share/icons so MPRIS widgets could find them. Basically if you set the DesktopEntry prop to the name of the fav icon my extension should be able to find the icon in ~/.local/share/icons

beingmohit commented 5 years ago

Thanks for the suggestions. Will add the raise method and icon feature as you described.

JasonLG1979 commented 5 years ago

To clarify the DesktopEntry prop should be the name of the file minus extension. So what-ever.png should just be what-ever.

beingmohit commented 5 years ago

@JasonLG1979 mpris:artUrl contains the image/icon url for the currently playing media. Can you use that instead? Adding desktop entry for each song does not seem like a good idea.

Plus using mpris:artUrl will make it compatible with all MPRIS bases tools

JasonLG1979 commented 5 years ago

@JasonLG1979 mpris:artUrl contains the image/icon url for the currently playing media. Can you use that instead? Adding desktop entry for each song does not seem like a good idea.

Plus using mpris:artUrl will make it compatible with all MPRIS bases tools

I'm talking about the "Player" icon as in the application that owns the MPRIS interface not the cover art. In 2nd thought it may be easier to just have your own icon and just use that instead of favicons. If you used favicons you'd have to convert them since GNOME at least can't use ico's.

JasonLG1979 commented 5 years ago

DesktopEntry is a more or less a static prop. Much like Identity.

JasonLG1979 commented 5 years ago

Here I just made this real quick. Heavily influenced by (read: basically a copy of) Google Music's favicon. browser-playerctl svg