beir-cellar / beir

A Heterogeneous Benchmark for Information Retrieval. Easy to use, evaluate your models across 15+ diverse IR datasets.
http://beir.ai
Apache License 2.0
1.55k stars 186 forks source link

Error in `beir/beir/retrieval/search/sparse/sparse_search.py` #60

Open jin530 opened 2 years ago

jin530 commented 2 years ago

https://github.com/UKPLab/beir/blob/568f4c34fa0be1901e2aaa8479978c9e54a1e377/beir/retrieval/search/sparse/sparse_search.py#L28-L34

Hello,

I think there is an error in sparse_search.py; only the first query in each batch is evaluated.

Thank you!

maximedb commented 2 years ago

Indeed! An easy fix would be to remove the step size self.batch_size?