Closed tstadel closed 1 year ago
@NThakur20 I'm happy to receive your comments about this draft. Let me know if moving score_function
is too intrusive. I just thought it makes more sense to have it only where you actually need it.
Hi @tstadel, thanks for the PR. I implemented the abstract base class in the latest revamping. I did not want to change the score function as users have always been using it in a particular way and I wish to change the functions as minimally as possible.
Thanks!
Proposed Changes:
RetrievalModel
ABCSparseSearch
,BM25Search
,DenseRetrievalFaissSearch
andDenseRetrievalExactSearch
inherit fromRetrievalModel
EvaluateRetrieval
receivesRetrievalModel
as paramretriever
toretrieval_model
inEvaluateRetrieval
score_function
param fromEvaluateRetrieval
toDenseRetrievalFaissSearch
andDenseRetrievalExactSearch
score_function
onEvaluateRetrieval
previouslycloses https://github.com/beir-cellar/beir/issues/84